zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on issue #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs
Date Wed, 06 Mar 2019 18:11:31 GMT
enixon commented on issue #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault
when hitting predefined XIDs
URL: https://github.com/apache/zookeeper/pull/831#issuecomment-470214811
 
 
   The code looks good to me.
   
   As for the unit test, making the counter global strikes me as overkill too but I'll let
someone who represents the project make the actual decision.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message