zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #840: WIP - Refactor ServerMetrics, make it a single instance
Date Mon, 04 Mar 2019 23:02:57 GMT
eolivelli commented on a change in pull request #840: WIP - Refactor ServerMetrics, make it
a single instance
URL: https://github.com/apache/zookeeper/pull/840#discussion_r262282219
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java
 ##########
 @@ -48,13 +48,21 @@ public void testResponseCache() throws Exception {
     }
 
     private void checkCacheStatus(long expectedHits, long expectedMisses) {
-        Map<String, Object> metrics = ServerMetrics.getAllValues();
+        
+        Map<String, Object> metrics = new HashMap<>();
 
 Review comment:
   This test needs the DefaultMetricsProvider

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message