From dev-return-78760-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Feb 26 01:41:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CCE36180626 for ; Tue, 26 Feb 2019 02:41:03 +0100 (CET) Received: (qmail 14224 invoked by uid 500); 26 Feb 2019 01:41:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 14210 invoked by uid 99); 26 Feb 2019 01:41:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Feb 2019 01:41:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 57C41C7797 for ; Tue, 26 Feb 2019 01:41:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id q2YAJBztfAUB for ; Tue, 26 Feb 2019 01:41:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E9C035F65D for ; Tue, 26 Feb 2019 01:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7BD11E00A9 for ; Tue, 26 Feb 2019 01:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 305AE2455B for ; Tue, 26 Feb 2019 01:41:00 +0000 (UTC) Date: Tue, 26 Feb 2019 01:41:00 +0000 (UTC) From: "maoling (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3289) Throw KeeperException with path in DataTree operations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777466#comment-16777466 ] maoling commented on ZOOKEEPER-3289: ------------------------------------ TisonKun - for the snippet you provided, it will not throw an exception *KeeperException.NoNodeException:/path1* or *KeeperException.NoNodeException:/path2* ??? - take a quick look at the code in the *CuratorTransactionImpl*,it is a issue about curator (\{#emotions_dlg.biggrin})? > Throw KeeperException with path in DataTree operations > ------------------------------------------------------ > > Key: ZOOKEEPER-3289 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3289 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.5.4, 3.4.13 > Reporter: TisonKun > Priority: Major > Fix For: 3.5.5, 3.4.14 > > > Currently, if ZooKeeper delete a znode that does not exist. It throws a {{KeeperException.NoNodeException}} without path message. It causes difficulty when user debug with ZooKeeper. For example, > Assume we try to do a transaction(with Curator encapsulation) > {code:java} > client.inTransaction() > .check().forPath(path1).and() > .delete().forPath(path2).and() > .commit() > {code} > if the statement throw an exception {{KeeperException.NoNodeException}} without path information, we can hardly know that it failed at {{check}} or {{delete}}. > Thus I propose throws KeeperException with path in DataTree operations. We can achieve this without burden. -- This message was sent by Atlassian JIRA (v7.6.3#76005)