From dev-return-78561-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Feb 15 22:54:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F6E4180651 for ; Fri, 15 Feb 2019 23:54:14 +0100 (CET) Received: (qmail 54685 invoked by uid 500); 15 Feb 2019 22:54:13 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 54674 invoked by uid 99); 15 Feb 2019 22:54:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Feb 2019 22:54:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 290DE18215E for ; Fri, 15 Feb 2019 22:54:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id koOuBQPt0oVq for ; Fri, 15 Feb 2019 22:54:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 36B565F401 for ; Fri, 15 Feb 2019 22:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 78B3DE2673 for ; Fri, 15 Feb 2019 22:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 34F64244E2 for ; Fri, 15 Feb 2019 22:45:00 +0000 (UTC) Date: Fri, 15 Feb 2019 22:45:00 +0000 (UTC) From: "Liam (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16769800#comment-16769800 ]=20 Liam edited comment on ZOOKEEPER-3280 at 2/15/19 10:44 PM: ----------------------------------------------------------- Jonathan, completely not the space to be asking this. I am trying to associated/correlate these struts STR numbers to CVE number= s. Example, I have CVE-2016-1182, but not sure how to relate it to a STR. Note: =C2=A0 I can delete afterwards I notice! was (Author: lmshov4@gmail.com): Jonathan, completely not the space to asking this. I am trying to associated/correlate these struts STR numbers to CVE numbers= . Example, I have CVE-2016-1182, but not sure how to relate it to a STR. > ClientCnxn xid rollover can break sessions > ------------------------------------------ > > Key: ZOOKEEPER-3280 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3280 > Project: ZooKeeper > Issue Type: Bug > Components: java client > Affects Versions: 3.4.6, 3.4.12 > Reporter: Jonathan Park > Priority: Major > Attachments: ZKOutOfOrder.java > > > =C2=A0 > {code:java} > 2019-02-15 13:40:21,471 [myid:] - DEBUG [main-SendThread(localhost:2181):= ClientCnxn$SendThread@759] - Got auth sessionid:0x168f2c5e9c60017 > 2019-02-15 13:40:21,472 [myid:] - WARN=C2=A0 [main-SendThread(localhost:2= 181):ClientCnxn$SendThread@1166] - Session 0x168f2c5e9c60017 for server loc= alhost/0:0:0:0:0:0:0:1:2181, unexpected error, closing socket connection an= d attempting reconnect > java.io.IOException: Xid out of order. Got Xid -3 with err 0 expected Xid= -4 for a packet with details: clientPath:null serverPath:null finished:fal= se header:: -4,8 replyHeader:: 0,0,-4 request:: '/,F response:: v{}=20 > at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.jav= a:828) > at org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java= :94) > at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketN= IO.java:366) > at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1143) > 2019-02-15 13:40:22,520 [myid:] - INFO [main-SendThread(localhost:2181):C= lientCnxn$SendThread@1027] - Opening socket connection to server localhost/= 127.0.0.1:2181. Will not attempt to authenticate using SASL (unknown error) > 2019-02-15 13:40:22,521 [myid:] - INFO [main-SendThread(localhost:2181):C= lientCnxn$SendThread@877] - Socket connection established to localhost/127.= 0.0.1:2181, initiating session > 2019-02-15 13:40:22,521 [myid:] - DEBUG [main-SendThread(localhost:2181):= ClientCnxn$SendThread@950] - Session establishment request sent on localhos= t/127.0.0.1:2181 > 2019-02-15 13:40:22,522 [myid:] - INFO [main-SendThread(localhost:2181):C= lientCnxn$SendThread@1301] - Session establishment complete on server local= host/127.0.0.1:2181, sessionid =3D 0x168f2c5e9c60017, negotiated timeout = =3D 30000 > 2019-02-15 13:40:22,525 [myid:] - DEBUG [main-SendThread(localhost:2181):= ClientCnxn$SendThread@742] - Got ping response for sessionid: 0x168f2c5e9c6= 0017 after 235329552ms > {code} > ClientCnxn xid's are tracked as java int's. For long-lived ZK clients thi= s can lead to rollover into the negative xid space. Xid =3D -4 is treated a= s a special xid reserved for auth requests. With xid rollover, a normal ZK = request can also have xid =3D -4 but the response will be treated as an aut= h response making subsequent packet processing error with the exception abo= ve. We can reproduce this more readily by changing the starting xid in Clie= ntCnxn from 1 to -100. The ZK client will transparently reconnect and estab= lish a new session but features that depended on the same session persistin= g will unnecessarily experience a disconnected event. > =C2=A0 > I've attached simple class with a main() method that reproduces the failu= re quickly against a local ZK server after modifying the initial value of C= lientCnxn.xid from 1 to -100.=C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)