From dev-return-78553-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Feb 15 21:50:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC574180763 for ; Fri, 15 Feb 2019 22:50:08 +0100 (CET) Received: (qmail 37812 invoked by uid 500); 15 Feb 2019 21:50:07 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 37677 invoked by uid 99); 15 Feb 2019 21:50:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Feb 2019 21:50:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0AC0DC638B for ; Fri, 15 Feb 2019 21:50:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id DwhGS5ohHpyg for ; Fri, 15 Feb 2019 21:50:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9F2025F3ED for ; Fri, 15 Feb 2019 21:50:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 58CC4E27BA for ; Fri, 15 Feb 2019 21:50:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0060F244FB for ; Fri, 15 Feb 2019 21:50:01 +0000 (UTC) Date: Fri, 15 Feb 2019 21:50:00 +0000 (UTC) From: "Jonathan Park (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Jonathan Park created ZOOKEEPER-3280: ---------------------------------------- Summary: ClientCnxn xid rollover can break sessions Key: ZOOKEEPER-3280 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3280 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.12, 3.4.6 Reporter: Jonathan Park Attachments: ZKOutOfOrder.java =C2=A0 {code:java} 181, unexpected error, closing socket connection and attempting reconnect java.io.IOException: Xid out of order. Got Xid -3 with err 0 expected Xid -= 4 for a packet with details: clientPath:null serverPath:null finished:false= header:: -4,8 replyHeader:: 0,0,-4 request:: '/,F response:: v{}=20 at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:= 828) at org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java:9= 4) at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO= .java:366) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1143) 2019-02-15 13:40:22,520 [myid:] - INFO [main-SendThread(localhost:2181):Cli= entCnxn$SendThread@1027] - Opening socket connection to server localhost/12= 7.0.0.1:2181. Will not attempt to authenticate using SASL (unknown error) 2019-02-15 13:40:22,521 [myid:] - INFO [main-SendThread(localhost:2181):Cli= entCnxn$SendThread@877] - Socket connection established to localhost/127.0.= 0.1:2181, initiating session 2019-02-15 13:40:22,521 [myid:] - DEBUG [main-SendThread(localhost:2181):Cl= ientCnxn$SendThread@950] - Session establishment request sent on localhost/= 127.0.0.1:2181 2019-02-15 13:40:22,522 [myid:] - INFO [main-SendThread(localhost:2181):Cli= entCnxn$SendThread@1301] - Session establishment complete on server localho= st/127.0.0.1:2181, sessionid =3D 0x168f2c5e9c60017, negotiated timeout =3D = 30000 2019-02-15 13:40:22,525 [myid:] - DEBUG [main-SendThread(localhost:2181):Cl= ientCnxn$SendThread@742] - Got ping response for sessionid: 0x168f2c5e9c600= 17 after 235329552ms {code} ClientCnxn xid's are tracked as java int's. For long-lived ZK clients this = can lead to rollover into the negative xid space. Xid =3D -4 is treated as = a special xid reserved for auth requests. With xid rollover, a normal ZK re= quest can also have xid =3D -4 but the response will be treated as an auth = response making subsequent packet processing error with the exception above= . We can reproduce this more readily by changing the starting xid in Client= Cnxn from 1 to -100. The ZK client will transparently reconnect and establi= sh a new session but features that depended on the same session persisting = will unnecessarily experience a disconnected event. =C2=A0 I've attached simple class with a main() method that reproduces the failure= quickly against a local ZK server after modifying the initial value of Cli= entCnxn.xid from 1 to -100.=C2=A0 =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)