From dev-return-78084-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Feb 5 05:18:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 019E8180651 for ; Tue, 5 Feb 2019 06:18:26 +0100 (CET) Received: (qmail 68799 invoked by uid 500); 5 Feb 2019 05:18:26 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 68787 invoked by uid 99); 5 Feb 2019 05:18:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Feb 2019 05:18:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ECC73183E4C for ; Tue, 5 Feb 2019 05:18:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.799 X-Spam-Level: * X-Spam-Status: No, score=1.799 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5_fX2HcVXMV3 for ; Tue, 5 Feb 2019 05:18:23 +0000 (UTC) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id AF95662408 for ; Tue, 5 Feb 2019 05:18:22 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id z10so924916pgp.7 for ; Mon, 04 Feb 2019 21:18:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6X9ZS13vvTTcd9SwkmWcjaTaYys97phg2nwoE3O1Bs8=; b=SJWPjjNsW0OBpK5VvYciO/3HmlVEqNf1S/hDLyvLgAIdEEk2d/qWXG4ZDLBPXL5ipw Le8tPpw5vXNa2leribTt6cLRz0pmQfUNKO06Bp/O1Gxrcpy1Iw9jSjACkl0MXkhKQIwU ddHLiYKUQz3wxvSm2Vtw9PLgq4UMR/0HgcMEKvWb5rx8oysnNFoFsR+EKPGEnj4ouU9O AHJEVIVABrbwKPNdsxpAxOPsvKcX19k33ZO6ONSMjN8hmA8AURPZULmq3mpL9TCC12dM lvrpf6GHZ6z4dUqlYKjX0R1TYg3KGVLo6vo8KpQM8ZhLjhp9b8Mey9syZWwnE8RQUPv9 Ahhw== X-Gm-Message-State: AHQUAuZZsmJpc0B4MPEnNBqlMfoIgCSo+8m1wzZyuLzbQEyX5ZqsIMSS 7QXqJnePMEh8UEKRlbSlhIatc74zrypU7Ys3N1ug1oFUhQOaFQ== X-Google-Smtp-Source: AHgI3IYljPB77nwVbztNzfgCPdMnu1MflwIWdmtaTiMwJDBNkdeBSYiX4Ma5H1/nVUNgrvCbzwj+sr06VRMSz5Em/os= X-Received: by 2002:a63:5153:: with SMTP id r19mr2873989pgl.281.1549343900889; Mon, 04 Feb 2019 21:18:20 -0800 (PST) MIME-Version: 1.0 References: <90C1C582-6BC9-47FF-9798-240120166E51@apache.org> In-Reply-To: From: Norbert Kalmar Date: Tue, 5 Feb 2019 05:18:09 +0000 Message-ID: Subject: Re: Maven migration and CI To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="000000000000d9364305811ebc8f" --000000000000d9364305811ebc8f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks guys, see https://github.com/apache/zookeeper/pull/802 Regards, Norbert On Tue, Feb 5, 2019 at 2:58 AM Enrico Olivelli wrote: > @Norbert will you send the patch ? > It just a one-liner > > Enrico > > > Il giorno lun 4 feb 2019 alle ore 15:44 Andor Molnar > ha scritto: > > > > Hi Enrico / Norbert, > > > > There=E2=80=99s one thing I recently noticed in the Maven build: it doe= sn=E2=80=99t > enforce the =E2=80=9Clanguage level=E2=80=9D which was set to 1.6 in the = Ant build of 3.4 > > For example, if I use =E2=80=9Cnew ArrayList<>()=E2=80=9D (diamond oper= ator) in the > code, I can build it with Maven, but not with Ant: > > > > error: diamond operator is not supported in -source 1.6 > > > > Can we do the same with the Maven build? > > > > Regards, > > Andor > > > > > > > > > > > On 2019. Jan 26., at 9:36, Enrico Olivelli > wrote: > > > > > > I am working on owasp plugin, this is needed for CI migration > > > > > > > > > Enrico > > > > > > Il giorno dom 6 gen 2019, 15:23 Norbert Kalmar > > > > ha scritto: > > > > > >> Great, thanks Enrico! > > >> > > >> > > >> On Fri, Jan 4, 2019 at 8:35 PM Enrico Olivelli > > >> wrote: > > >> > > >>> Here it is the build on master > > >>> https://builds.apache.org/job/zookeeper-master-maven/3/ > > >>> > > >>> This is running only > > >>> mvn verify > > >>> > > >>> and tests are passing, we have to enable all of the other plugins > > >>> (spotbugs, OWASP, code coverage...) and enable the C client profile > > >>> but it is a good starting point > > >>> > > >>> Enrico > > >>> > > >>> Il giorno ven 4 gen 2019 alle ore 10:43 Norbert Kalmar > > >>> ha scritto: > > >>>> > > >>>> Nicely planned, thanks Enrico! > > >>>> > > >>>> On Fri, Jan 4, 2019 at 9:33 AM Andor Molnar > wrote: > > >>>> > > >>>>> Awesome! > > >>>>> > > >>>>> I really looking forward to it. > > >>>>> > > >>>>> Andor > > >>>>> > > >>>>> > > >>>>>> On 2019. Jan 3., at 22:34, Enrico Olivelli > > >>> wrote: > > >>>>>> > > >>>>>> Hi Zookeepers > > >>>>>> Now that we have Maven it is time to set up new CI jobs and > compare > > >>> the > > >>>>>> results with the Ant based build. > > >>>>>> > > >>>>>> My proposal is to set up a few jobs and see the results. When > > >> Norbert > > >>>>>> finishes the migration and we are happy we will drop Ant CI. > > >>>>>> > > >>>>>> I would start with a daily job for master which runs all of the > > >> test > > >>>>> suites > > >>>>>> + rat + spotbugs. > > >>>>>> > > >>>>>> As a second step I would introduce a new precommit job which > builds > > >>> the > > >>>>>> patch using Maven, so in github we will have two 'status lines' > > >>>>>> > > >>>>>> Then I would add code coverage reports, OWASP.... > > >>>>>> > > >>>>>> The final step will be to introduce Jenkins DSL based > configuration > > >>> for > > >>>>> CI, > > >>>>>> this way committers will have full control on CI, reviews of the > > >>>>>> configuration changes will be possible...(we could use Jenkinsfi= le > > >>>>> approach > > >>>>>> if you prefer) > > >>>>>> > > >>>>>> I am able to work on ASF CI so if you allow me I will start with > > >> some > > >>>>>> prototype > > >>>>>> > > >>>>>> Enrico > > >>>>>> > > >>>>>> -- > > >>>>>> > > >>>>>> > > >>>>>> -- Enrico Olivelli > > >>>>> > > >>>>> > > >>> > > >> > > > --000000000000d9364305811ebc8f--