From dev-return-78427-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Feb 12 09:56:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2705F18002F for ; Tue, 12 Feb 2019 10:56:45 +0100 (CET) Received: (qmail 97678 invoked by uid 500); 12 Feb 2019 09:56:45 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 97658 invoked by uid 99); 12 Feb 2019 09:56:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2019 09:56:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1A9FBC068B for ; Tue, 12 Feb 2019 09:56:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id NfJUs26vVPM1 for ; Tue, 12 Feb 2019 09:56:41 +0000 (UTC) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id ABA5A5FAF9 for ; Tue, 12 Feb 2019 09:56:41 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id g189so1018020pgc.5 for ; Tue, 12 Feb 2019 01:56:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=NrXM2eKvWiTolMYUucdUKGut56hRAdIDI/1lGK3Jdnc=; b=EsKDcp8zJkmoJpDhTqzrMwEjF0naTzwBmdqvbJ6yFKv9UI091KE6UM9B2oPTjT2AU6 nqGHLT4DYcuaWLt0KkSFsrKGCJ88fc64yZe26n8b8l3u1HRcW5pZh2Z5te6bQhjeW8BS LY22CugpDkztXnhPOhzmYmWnc+PX6Jq6LrrAqTNT5Om1+gLeTZRD1uaAhNSIgY0jzJUe OFEf2pe9OnLS115p2wTjatv5BOM37ITXGJ9Nqfz+MUNIHkfHiLuj2BEAT8XEfjxqNKrQ CGYRA9v3HHC1oTQOs+x2PRn+QlbpBvWolamH/PegWPreA9er5D6xdQ6wSAvR5n0vyLo0 2+yg== X-Gm-Message-State: AHQUAub7xpIXEPYQZ5ZDhCdaDFNDKt0g2X55euzQmf7OJsiJAsaRVCj/ +0Q0roB1Bov4PpTg1fJkapq/8/M1/bfsSakPQ3vvKraB X-Google-Smtp-Source: AHgI3IZZuJkcLLMfDSKY4bI7uFbR8gtcbuDbusxhZOuQ37Sn1l1r0VjwKB0XwVTNPkoBA1Nyskoib2sa5NmeKNG3lTE= X-Received: by 2002:a63:fc59:: with SMTP id r25mr2923848pgk.302.1549965395270; Tue, 12 Feb 2019 01:56:35 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Norbert Kalmar Date: Tue, 12 Feb 2019 10:56:24 +0100 Message-ID: Subject: Re: ZooKeeper and checkstyle To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="000000000000ccbc660581af70c2" --000000000000ccbc660581af70c2 Content-Type: text/plain; charset="UTF-8" There was some discussion about checkstyle a while back, but I can't find it. Maybe it was on a PR. We concluded that we have so many violations it doesn't make sense to activate. But as you suggested, I think the same was concluded, that it should be activated on master sooner or later, should only give warnings, no build failure for starter. And the majority of warnings could be fixed in a single big PR as it is mainly formatting. Regards, Norbert On Mon, Feb 11, 2019 at 10:50 PM Enrico Olivelli wrote: > Hi, > I did not notice that we already have checkstyle configuration in the ANT > build. > > This is the command > ant checkstyle > > Unfortunately we have hundreds of violations.... > > I think it will be a great step to re-enable checkstyle on master > after we get a "stable" release of the 3.5 branch. > > I expect that after that point we will be free to perform important > (in terms of numbers of lines) changes and code repository layout > changes. > > > Enrico > --000000000000ccbc660581af70c2--