From dev-return-78428-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Feb 12 10:04:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 84FB618002F for ; Tue, 12 Feb 2019 11:04:29 +0100 (CET) Received: (qmail 31824 invoked by uid 500); 12 Feb 2019 10:04:28 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 31807 invoked by uid 99); 12 Feb 2019 10:04:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2019 10:04:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 26E93CB1A4 for ; Tue, 12 Feb 2019 10:04:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.202 X-Spam-Level: X-Spam-Status: No, score=-0.202 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1p-dC9VIY8pi for ; Tue, 12 Feb 2019 10:04:25 +0000 (UTC) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id DE8F35F1BE for ; Tue, 12 Feb 2019 10:04:24 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id c19-v6so1688424lja.5 for ; Tue, 12 Feb 2019 02:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=AaSWMlXfzdOSQi9pjj5pm7Ib8wu0lhaTl6ksxVWRHjk=; b=IJZVOKX2k+7GMmj6SW6V+V7Y/ORPxkuBMswP/Vmp9cWb6mOOHfq8f4I0w8tkJ3OYJB ThqZkDVtZEcbkAEtnwnoUl/TVIYTyYeVUwkxqC8Xz2vysGAtGmj3KTERcp/ij9x96g+c RTaYO/h22rPMbOCfrNQ0L4tlmYbNicxtqF1xwb15tvgOByhEf5c2lWD9qVvAXuc3ATgC xGhFiSv/Rq3ZG+cpWJUb2VxBvM6I9TRucWwZWxOGIR4PAyyazSSYGPsDhIRcyxYQy9TF jz+DNZwsQ/c+hMRp8JMcZSIZqQQR1wUCWaJF78Sc8JGqf+0DPp+beIW9mYPFE7M7fM4C WmMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=AaSWMlXfzdOSQi9pjj5pm7Ib8wu0lhaTl6ksxVWRHjk=; b=uLTxK8hxTg5SfinGUB68vd7uinmo/e3fkMa7XSNN9XrJqyT9eXW+s2HED5vbU/VIOi 4ca9QfH1xUktW/R1xYscwxH6L5BBMIpyO6y9hCzurOEkSRCzpJmDCZNKCARWKS3uyDzN nq7xzpqJVb40olEQhSte60UeyVrWB8vova8hK2Xg8Yhhtcc0m50G2hD4tZrOwKxLZuPM 9L5tedpH2Spq+xhbrXBx47kyuMvhy5Ba6cq6C7NJ8o8RkQeBBgNHBlAJDW8hZ6p7wtc7 sixT3LyPmfLpN9ASC2gaKiv52cNtcwlFBB5lfTjVCvUAwibOy/1S1bIGfdovCBqrPq8e YJjg== X-Gm-Message-State: AHQUAuY32Rof5nVz3yn3tmkImNOzUq8PlBlW5ykKFQd5cekyr0jHrmSO nqPrhaHsDG1VfdAzWeDJIr5oth4GaS6bhIDfrd/N/g== X-Google-Smtp-Source: AHgI3Iae+NR/zxu4WGgeSmRo6loR+OUqD+ipc/7pL0UOC2E1pO0vYYXTXVj/LSsjwlWP4GqdVudVY7vqLzOnCSTme+Y= X-Received: by 2002:a2e:9209:: with SMTP id k9-v6mr1835033ljg.12.1549965863535; Tue, 12 Feb 2019 02:04:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Tue, 12 Feb 2019 11:04:10 +0100 Message-ID: Subject: Re: ZooKeeper and checkstyle To: DevZooKeeper Content-Type: text/plain; charset="UTF-8" Il giorno mar 12 feb 2019 alle ore 10:56 Norbert Kalmar ha scritto: > > There was some discussion about checkstyle a while back, but I can't find > it. Maybe it was on a PR. > We concluded that we have so many violations it doesn't make sense to > activate. But as you suggested, I think the same was concluded, that it > should be activated on master sooner or later, should only give warnings, > no build failure for starter. And the majority of warnings could be fixed > in a single big PR as it is mainly formatting. I would prefer to really activate checkstyle on master, once we have released 3.5. IMHO Having warnings is not useful. Enrico > > Regards, > Norbert > > On Mon, Feb 11, 2019 at 10:50 PM Enrico Olivelli > wrote: > > > Hi, > > I did not notice that we already have checkstyle configuration in the ANT > > build. > > > > This is the command > > ant checkstyle > > > > Unfortunately we have hundreds of violations.... > > > > I think it will be a great step to re-enable checkstyle on master > > after we get a "stable" release of the 3.5 branch. > > > > I expect that after that point we will be free to perform important > > (in terms of numbers of lines) changes and code repository layout > > changes. > > > > > > Enrico > >