From dev-return-78060-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Feb 4 15:51:28 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4897180651 for ; Mon, 4 Feb 2019 16:51:27 +0100 (CET) Received: (qmail 42939 invoked by uid 500); 4 Feb 2019 15:51:27 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 42926 invoked by uid 99); 4 Feb 2019 15:51:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2019 15:51:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DC14FCB822 for ; Mon, 4 Feb 2019 15:51:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.203 X-Spam-Level: X-Spam-Status: No, score=-0.203 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YKuWlejRdhMC for ; Mon, 4 Feb 2019 15:51:24 +0000 (UTC) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 441525F65D for ; Mon, 4 Feb 2019 15:51:24 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id e27so237814lfj.8 for ; Mon, 04 Feb 2019 07:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=11A2xJTKmtfVi6evM/P2SIe2Pp3bDzPUSBXhHJeXIOU=; b=vadZvwwLaux2XIw3UTIhrtbqD/xtsj4wNEtDXUOEce69117fbwxge6Xh2aLvNJFvJs t+imKrDgsjjWffP9NEC4acBSBKog+JacU6dcF5/++j/sVBSQ9TKSwTg//WzshRpqtmHy faL8nDz/ayvBndo4nLuNMyY6I+/dz7wmb9Rtn9WNZHfUa3Ikvm/tR8qHAnWeh1NGymyM Yj2Cc6s8YmETnHUur5fT1jCZBVfGW/A8QrOzan79riE7ObqxPuoEi0bcL+SJKollHzV3 J3vpCtFKc6DYLEW+UYo51eHOOCt7iZuPQ2kV/MYkH2SGIP7DvStCnV9v5WwY3/Foswsm ypCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=11A2xJTKmtfVi6evM/P2SIe2Pp3bDzPUSBXhHJeXIOU=; b=LLJdUXiufrK2my8fcP/JBQFktvqV9lPIooTC5ED7Fl9QkrHuaBlWbB4QioEoD0FvnW Xg4wWwyql3BvQoIsnROCM9zMeb8WM2JP+Y0wjfAL/+qS04mQdhABXgtBkdk17EZFWLhl zvAYdj5Z/DU7su7fKiCRpWaEBJTNBkdzHxVx9/0OLHjDKZBWSPa3ifbxMbfqnCJpeF6w bjxyjTs9hT+i/BK0FTdV9dLuZ95Eu/wLcrUtrxGzbAIYhfGqrf5sCgXFP9NgJyA4kery Y01EWFER8lA3gP5ogrwNM4rluYooH6Esl4FyR6jJDxA5KNBdQKgwobDeVnX2HuolOBur R6+A== X-Gm-Message-State: AHQUAubjd6cSEYk4O3hWs2fcCfdVaP9ITcpyXhswZHxZ/qp8Ty1biYQh hgrqU0nrVrbG1RurimkO/GlpGnsdAD5/HvcBEdpguw== X-Google-Smtp-Source: AHgI3IZ9kgHDqctzhQ+OTR/aaBxgYB5FcBqAjS1xVneDpDmmLiP74pA6qCL0St0FhYDfrhmddTTrx3Sl5DV3qQg5yNs= X-Received: by 2002:a19:2906:: with SMTP id p6mr6442lfp.17.1549295482026; Mon, 04 Feb 2019 07:51:22 -0800 (PST) MIME-Version: 1.0 References: <90C1C582-6BC9-47FF-9798-240120166E51@apache.org> In-Reply-To: From: Enrico Olivelli Date: Mon, 4 Feb 2019 16:51:08 +0100 Message-ID: Subject: Re: Maven migration and CI To: DevZooKeeper Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable @Norbert will you send the patch ? It just a one-liner Enrico Il giorno lun 4 feb 2019 alle ore 15:44 Andor Molnar ha scritto: > > Hi Enrico / Norbert, > > There=E2=80=99s one thing I recently noticed in the Maven build: it doesn= =E2=80=99t enforce the =E2=80=9Clanguage level=E2=80=9D which was set to 1.= 6 in the Ant build of 3.4 > For example, if I use =E2=80=9Cnew ArrayList<>()=E2=80=9D (diamond operat= or) in the code, I can build it with Maven, but not with Ant: > > error: diamond operator is not supported in -source 1.6 > > Can we do the same with the Maven build? > > Regards, > Andor > > > > > > On 2019. Jan 26., at 9:36, Enrico Olivelli wrote: > > > > I am working on owasp plugin, this is needed for CI migration > > > > > > Enrico > > > > Il giorno dom 6 gen 2019, 15:23 Norbert Kalmar > > ha scritto: > > > >> Great, thanks Enrico! > >> > >> > >> On Fri, Jan 4, 2019 at 8:35 PM Enrico Olivelli > >> wrote: > >> > >>> Here it is the build on master > >>> https://builds.apache.org/job/zookeeper-master-maven/3/ > >>> > >>> This is running only > >>> mvn verify > >>> > >>> and tests are passing, we have to enable all of the other plugins > >>> (spotbugs, OWASP, code coverage...) and enable the C client profile > >>> but it is a good starting point > >>> > >>> Enrico > >>> > >>> Il giorno ven 4 gen 2019 alle ore 10:43 Norbert Kalmar > >>> ha scritto: > >>>> > >>>> Nicely planned, thanks Enrico! > >>>> > >>>> On Fri, Jan 4, 2019 at 9:33 AM Andor Molnar wrote= : > >>>> > >>>>> Awesome! > >>>>> > >>>>> I really looking forward to it. > >>>>> > >>>>> Andor > >>>>> > >>>>> > >>>>>> On 2019. Jan 3., at 22:34, Enrico Olivelli > >>> wrote: > >>>>>> > >>>>>> Hi Zookeepers > >>>>>> Now that we have Maven it is time to set up new CI jobs and compar= e > >>> the > >>>>>> results with the Ant based build. > >>>>>> > >>>>>> My proposal is to set up a few jobs and see the results. When > >> Norbert > >>>>>> finishes the migration and we are happy we will drop Ant CI. > >>>>>> > >>>>>> I would start with a daily job for master which runs all of the > >> test > >>>>> suites > >>>>>> + rat + spotbugs. > >>>>>> > >>>>>> As a second step I would introduce a new precommit job which build= s > >>> the > >>>>>> patch using Maven, so in github we will have two 'status lines' > >>>>>> > >>>>>> Then I would add code coverage reports, OWASP.... > >>>>>> > >>>>>> The final step will be to introduce Jenkins DSL based configuratio= n > >>> for > >>>>> CI, > >>>>>> this way committers will have full control on CI, reviews of the > >>>>>> configuration changes will be possible...(we could use Jenkinsfile > >>>>> approach > >>>>>> if you prefer) > >>>>>> > >>>>>> I am able to work on ASF CI so if you allow me I will start with > >> some > >>>>>> prototype > >>>>>> > >>>>>> Enrico > >>>>>> > >>>>>> -- > >>>>>> > >>>>>> > >>>>>> -- Enrico Olivelli > >>>>> > >>>>> > >>> > >> >