From dev-return-78749-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Feb 25 15:11:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AF7B9180656 for ; Mon, 25 Feb 2019 16:11:47 +0100 (CET) Received: (qmail 63189 invoked by uid 500); 25 Feb 2019 15:11:46 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 62986 invoked by uid 99); 25 Feb 2019 15:11:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Feb 2019 15:11:46 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] mookid8000 opened a new pull request #834: improve error message when JAVA_HOME is set to the wrong value Message-ID: <155110750568.12606.16093729621776718502.gitbox@gitbox.apache.org> Date: Mon, 25 Feb 2019 15:11:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mookid8000 opened a new pull request #834: improve error message when JAVA_HOME is set to the wrong value URL: https://github.com/apache/zookeeper/pull/834 This is small (Windows-based) developer usability improvement. When the `JAVA_HOME` environment variable is set, but the value is wrong (so that `JAVA_HOME` + `/bin/java.exe` does not point correctly to `java.exe`), the startup script will simply fail with the message ```dos Error: JAVA_HOME is incorrectly set. ``` which is a bummer. 😞 With this tiny change, the error message will be much friendlier: ```dos Error: JAVA_HOME is incorrectly set: C:\Program Files\Java\jre1.8.0_201\bin Expected to find java.exe here: C:\Program Files\Java\jre1.8.0_201\bin\bin\java.exe ``` (in this case showing a situation where one has inadvertently included `/bin` in the `JAVA_HOME` environment variable). This will also give a nicer error message in situations, where the JRE has been updated, and the one pointed to by `JAVA_HOME` has been uninstalled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services