From dev-return-78435-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Feb 12 13:22:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1AB50180745 for ; Tue, 12 Feb 2019 14:22:10 +0100 (CET) Received: (qmail 62235 invoked by uid 500); 12 Feb 2019 13:22:10 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 62162 invoked by uid 99); 12 Feb 2019 13:22:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2019 13:22:10 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] nkalmar commented on a change in pull request #817: ZOOKEEPER-3275: Fix release targets: package, tar, mvn-deploy Message-ID: <154997772942.13670.5082071420997428126.gitbox@gitbox.apache.org> Date: Tue, 12 Feb 2019 13:22:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nkalmar commented on a change in pull request #817: ZOOKEEPER-3275: Fix release targets: package, tar, mvn-deploy URL: https://github.com/apache/zookeeper/pull/817#discussion_r255948513 ########## File path: build.xml ########## @@ -862,7 +857,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> - + Review comment: Since paths has been modified, you also need to edit releaseaudit target, excludes. See here which files are not excluded: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/3290/artifact/patchprocess/patchReleaseAuditProblems.txt ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services