From dev-return-78274-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Feb 7 06:10:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1226918067A for ; Thu, 7 Feb 2019 07:10:14 +0100 (CET) Received: (qmail 77907 invoked by uid 500); 7 Feb 2019 06:10:14 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 77895 invoked by uid 99); 7 Feb 2019 06:10:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Feb 2019 06:10:13 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] anmolnar edited a comment on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments Message-ID: <154951981344.8098.10401576893219083816.gitbox@gitbox.apache.org> Date: Thu, 07 Feb 2019 06:10:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar edited a comment on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-461299559 Thanks @ivmaykov , that was quick. I'll review this today. Out of interest, @normanmaurer , was my suspicion correct about Netty 3 doesn't close NIO selectors correctly and that's why Java 11 keeps sockets open. We experienced a lot of "bind exceptions" in 3.5 unit tests and ended up upgrading to Netty 4. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services