From dev-return-78246-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Feb 6 19:39:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 25A5A180679 for ; Wed, 6 Feb 2019 20:39:20 +0100 (CET) Received: (qmail 80029 invoked by uid 500); 6 Feb 2019 19:39:20 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 80018 invoked by uid 99); 6 Feb 2019 19:39:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2019 19:39:20 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix Message-ID: <154948195950.26147.9984297232132693479.gitbox@gitbox.apache.org> Date: Wed, 06 Feb 2019 19:39:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r254421059 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java ########## @@ -324,30 +260,42 @@ public void operationComplete(ChannelFuture future) CnxnChannelHandler channelHandler = new CnxnChannelHandler(); - NettyServerCnxnFactory() { - bootstrap = new ServerBootstrap( - new NioServerSocketChannelFactory( - Executors.newCachedThreadPool(), - Executors.newCachedThreadPool())); - // parent channel - bootstrap.setOption("reuseAddress", true); - // child channels - bootstrap.setOption("child.tcpNoDelay", true); - /* set socket linger to off, so that socket close does not block */ - bootstrap.setOption("child.soLinger", -1); - bootstrap.setPipelineFactory(new ChannelPipelineFactory() { - @Override - public ChannelPipeline getPipeline() throws Exception { - ChannelPipeline p = Channels.pipeline(); - if (secure) { - initSSL(p); - } - p.addLast("servercnxnfactory", channelHandler); + private ServerBootstrap configureBootstrapAllocator(ServerBootstrap bootstrap) { + ByteBufAllocator testAllocator = TEST_ALLOCATOR.get(); + if (testAllocator != null) { + return bootstrap + .option(ChannelOption.ALLOCATOR, testAllocator) + .childOption(ChannelOption.ALLOCATOR, testAllocator); + } else { + return bootstrap; + } + } - return p; - } - }); + NettyServerCnxnFactory() { x509Util = new ClientX509Util(); + + EventLoopGroup bossGroup = NettyUtils.newNioOrEpollEventLoopGroup(); + EventLoopGroup workerGroup = NettyUtils.newNioOrEpollEventLoopGroup(); Review comment: Kind of.... each bind will have one channel but I would not expect to have thousands of these which means you should still be good with either handle all of these with just one thread or use the same group as boss and worker. If you use the same group you will handle accept calls + other IO on the same threads. Usually you only need a separate boss group if you need to accept a ton of connections very fast and want to ensure other IO will not slow these down ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services