From dev-return-78188-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Feb 6 13:34:22 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E948D18067A for ; Wed, 6 Feb 2019 14:34:21 +0100 (CET) Received: (qmail 34536 invoked by uid 500); 6 Feb 2019 13:34:12 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 33115 invoked by uid 99); 6 Feb 2019 13:34:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2019 13:34:11 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix Message-ID: <154946005096.25684.1713371055555044561.gitbox@gitbox.apache.org> Date: Wed, 06 Feb 2019 13:34:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r254248090 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java ########## @@ -291,33 +355,36 @@ private void doWrite(List pendingQueue, Packet p, ClientCnxn cnxn) { pendingQueue.add(p); } } - sendPkt(p); + sendPktOnly(p); } if (outgoingQueue.isEmpty()) { break; } p = outgoingQueue.remove(); } + // TODO: maybe we should flush in the loop above every N packets/bytes? + // But, how do we determine the right value for N ... + channel.flush(); Review comment: That said the easiest way to optimise this somehow is to add the `FlushConsolidationHandler` to the pipeline. It should be placed before your client / server handler: https://github.com/netty/netty/blob/netty-4.1.33.Final/handler/src/main/java/io/netty/handler/flush/FlushConsolidationHandler.java ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services