From dev-return-78189-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Feb 6 13:34:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4F95D180679 for ; Wed, 6 Feb 2019 14:34:20 +0100 (CET) Received: (qmail 34559 invoked by uid 500); 6 Feb 2019 13:34:12 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 33146 invoked by uid 99); 6 Feb 2019 13:34:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2019 13:34:11 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix Message-ID: <154946005093.25693.12462721231953798280.gitbox@gitbox.apache.org> Date: Wed, 06 Feb 2019 13:34:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit normanmaurer commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r254267679 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java ########## @@ -303,19 +277,126 @@ private boolean checkFourLetterWord(final Channel channel, } } - public void receiveMessage(ChannelBuffer message) { + /** + * Process incoming message. This should only be called from the event + * loop thread. + * @param buf the message bytes to process. + */ + void processMessage(ByteBuf buf) { + assert channel.eventLoop().inEventLoop(); + if (LOG.isDebugEnabled()) { + LOG.debug("0x{} queuedBuffer: {}", + Long.toHexString(sessionId), + queuedBuffer); + } + + if (LOG.isTraceEnabled()) { + LOG.trace("0x{} buf {}", + Long.toHexString(sessionId), + ByteBufUtil.hexDump(buf)); + } + + if (throttled.get()) { + LOG.debug("Received message while throttled"); + // we are throttled, so we need to queue + if (queuedBuffer == null) { + LOG.debug("allocating queue"); + queuedBuffer = channel.alloc().buffer(buf.readableBytes()); Review comment: Another thing you could do is to not allocate at all but call `buf.retainedDuplicate()` and store a reference to the returned duplicate directly. You can then still write into this one later if needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services