From dev-return-78149-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Feb 6 10:07:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B264118067A for ; Wed, 6 Feb 2019 11:07:39 +0100 (CET) Received: (qmail 32140 invoked by uid 500); 6 Feb 2019 10:07:38 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 32129 invoked by uid 99); 6 Feb 2019 10:07:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2019 10:07:38 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] anmolnar edited a comment on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly Message-ID: <154944765813.1082.10603263705731865934.gitbox@gitbox.apache.org> Date: Wed, 06 Feb 2019 10:07:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar edited a comment on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-460967355 @nkalmar @eolivelli @tamaashu Where are we with this patch? Is it ready to be committed or something is missing? Source tarballs looks OK to me, but there's also an empty `zookeeper-3.6.0-SNAPSHOT-tests.jar`. I think we don't need that. Regarding the convenience tarball, I don't see there's is a consensus in the community, so we can leave it for a later patch if needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services