From dev-return-78069-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Feb 4 16:35:16 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 223EF180679 for ; Mon, 4 Feb 2019 17:35:15 +0100 (CET) Received: (qmail 35837 invoked by uid 500); 4 Feb 2019 16:35:15 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 35826 invoked by uid 99); 4 Feb 2019 16:35:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2019 16:35:15 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] eolivelli commented on a change in pull request #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade Message-ID: <154929811459.18943.14746412805858840082.gitbox@gitbox.apache.org> Date: Mon, 04 Feb 2019 16:35:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on a change in pull request #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#discussion_r253362595 ########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/SessionTimeoutTest.java ########## @@ -18,21 +18,13 @@ package org.apache.zookeeper.test; -import org.apache.zookeeper.CreateMode; -import org.apache.zookeeper.KeeperException; -import org.apache.zookeeper.TestableZooKeeper; -import org.apache.zookeeper.WatchedEvent; -import org.apache.zookeeper.Watcher; -import org.apache.zookeeper.ZooDefs; -import org.apache.zookeeper.ZooKeeper; -import org.apache.zookeeper.data.Stat; +import org.apache.zookeeper.*; Review comment: Nit: I am not sure we are preferring star import ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services