From dev-return-78042-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Feb 3 00:42:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0C735180656 for ; Sun, 3 Feb 2019 01:42:52 +0100 (CET) Received: (qmail 18021 invoked by uid 500); 3 Feb 2019 00:42:52 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 18009 invoked by uid 99); 3 Feb 2019 00:42:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2019 00:42:52 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] ivmaykov commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix Message-ID: <154915457131.19072.6859279878428983189.gitbox@gitbox.apache.org> Date: Sun, 03 Feb 2019 00:42:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ivmaykov commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253283303 ########## File path: build.xml ########## @@ -36,7 +36,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> - + Review comment: Sure, let's do it in a separate PR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services