zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Norbert Kalmar <nkal...@cloudera.com.INVALID>
Subject Re: Pull requests validation - Maven is active - heads up!
Date Wed, 06 Feb 2019 15:40:39 GMT
For me, option 2 sounds good, and I think it's better to go for smaller
jobs from the beginning. It will be also helpful in identifying the
problems on the PRs seeing the different tasks fail/pass.

Thanks for taking this up Enrico!

Best regards,
Norbert

On Wed, Feb 6, 2019 at 4:35 PM Enrico Olivelli <eolivelli@gmail.com> wrote:

> With Andor and Norbert we are thinking to not run 'contrib' tests
> against Pull Requests.
>
> I have two proposals: Two "big" jobs  vs "many small jobs"
>
> 1) Two big jobs:
> - One ANT build (the current one)
> - One Maven Build (build and test java core,  c-client and run spotbugs)
>
> 2) Many small jobs:
> - One ANT build (the current one)
> - Maven build with "core java"
> - Maven build with  C client (builds java and runs tests on C client)
> - Maven build with spotbugs (and checkstyle soon...)
> - In the future Maven build with integration tests,  backward
> compatibility tests....
>
> In the mid term option 2) is better.
> In the short term option 1) works as well.
>
> I will be happy to work on this stuff
>
> Best regards
> Enrico
>
>
> Il giorno mar 5 feb 2019 alle ore 16:07 Enrico Olivelli
> <eolivelli@gmail.com> ha scritto:
> >
> >
> >
> > Il giorno mar 5 feb 2019, 15:47 Norbert Kalmar
> <nkalmar@cloudera.com.invalid> ha scritto:
> >>
> >> Great, thanks!
> >>
> >> One question: 3.4 builds are failing. It's because we run the tests on 1
> >> thread. I modified the main pom.xml's fork count to 1, but it looks
> like it
> >> is still running parallel. Do you override forkcount on the job? (I
> can't
> >> see Jenkins config). It should be changed to 1, as PortAssigment
> implies it
> >> is not run across multiple JVMs.
> >
> >
> >
> > No, just
> > mvn verify spotbugs:check
> >
> > Enrico
> >
> >>
> >> Regards,
> >> Norbert
> >>
> >> On Tue, Feb 5, 2019 at 5:32 AM Patrick Hunt <phunt@apache.org> wrote:
> >>
> >> > Looks good. Thanks Enrico!
> >> >
> >> > Patrick
> >> >
> >> > On Sat, Feb 2, 2019 at 1:32 AM Enrico Olivelli <eolivelli@gmail.com>
> >> > wrote:
> >> >
> >> > > Hi ZooKeepers,
> >> > > I have enabled validation of Pull Requests with Maven.
> >> > >
> >> > > In order to trigger the tests with ANT add a comment with:
> >> > > retest ant build
> >> > >
> >> > > In order to trigger the tests with MAVEN  add a comment with:
> >> > > retest maven build
> >> > >
> >> > >
> >> > >
> >> > > see this configuration for reference
> >> > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> >> > >
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/
> >> > >
> >> > > I have updated the wiki page
> >> > >
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> >> > >
> >> > >
> >> > > Enjoy Maven !!
> >> > >
> >> > > Enrico
> >> > >
> >> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message