zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Enrico Olivelli <eolive...@gmail.com>
Subject Re: Pull requests validation - Maven is active - heads up!
Date Tue, 05 Feb 2019 15:07:34 GMT
Il giorno mar 5 feb 2019, 15:47 Norbert Kalmar <nkalmar@cloudera.com.invalid>
ha scritto:

> Great, thanks!
>
> One question: 3.4 builds are failing. It's because we run the tests on 1
> thread. I modified the main pom.xml's fork count to 1, but it looks like it
> is still running parallel. Do you override forkcount on the job? (I can't
> see Jenkins config). It should be changed to 1, as PortAssigment implies it
> is not run across multiple JVMs.
>


No, just
mvn verify spotbugs:check

Enrico


> Regards,
> Norbert
>
> On Tue, Feb 5, 2019 at 5:32 AM Patrick Hunt <phunt@apache.org> wrote:
>
> > Looks good. Thanks Enrico!
> >
> > Patrick
> >
> > On Sat, Feb 2, 2019 at 1:32 AM Enrico Olivelli <eolivelli@gmail.com>
> > wrote:
> >
> > > Hi ZooKeepers,
> > > I have enabled validation of Pull Requests with Maven.
> > >
> > > In order to trigger the tests with ANT add a comment with:
> > > retest ant build
> > >
> > > In order to trigger the tests with MAVEN  add a comment with:
> > > retest maven build
> > >
> > >
> > >
> > > see this configuration for reference
> > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> > >
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/
> > >
> > > I have updated the wiki page
> > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> > >
> > >
> > > Enjoy Maven !!
> > >
> > > Enrico
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message