zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Enrico Olivelli <eolive...@gmail.com>
Subject Re: Maven migration and CI
Date Mon, 04 Feb 2019 15:51:08 GMT
@Norbert will you send the patch ?
It just a one-liner

Enrico


Il giorno lun 4 feb 2019 alle ore 15:44 Andor Molnar
<andor@apache.org> ha scritto:
>
> Hi Enrico / Norbert,
>
> There’s one thing I recently noticed in the Maven build: it doesn’t enforce the “language
level” which was set to 1.6 in the Ant build of 3.4
> For example, if I use “new ArrayList<>()” (diamond operator) in the code, I
can build it with Maven, but not with Ant:
>
> error: diamond operator is not supported in -source 1.6
>
> Can we do the same with the Maven build?
>
> Regards,
> Andor
>
>
>
>
> > On 2019. Jan 26., at 9:36, Enrico Olivelli <eolivelli@gmail.com> wrote:
> >
> > I am working on owasp plugin, this is needed for CI migration
> >
> >
> > Enrico
> >
> > Il giorno dom 6 gen 2019, 15:23 Norbert Kalmar <nkalmar@cloudera.com.invalid>
> > ha scritto:
> >
> >> Great, thanks Enrico!
> >>
> >>
> >> On Fri, Jan 4, 2019 at 8:35 PM Enrico Olivelli <eolivelli@gmail.com>
> >> wrote:
> >>
> >>> Here it is the build on master
> >>> https://builds.apache.org/job/zookeeper-master-maven/3/
> >>>
> >>> This is running only
> >>> mvn verify
> >>>
> >>> and tests are passing, we have  to enable all of the other plugins
> >>> (spotbugs, OWASP, code coverage...) and enable the C client profile
> >>> but it is a good starting point
> >>>
> >>> Enrico
> >>>
> >>> Il giorno ven 4 gen 2019 alle ore 10:43 Norbert Kalmar
> >>> <nkalmar@cloudera.com.invalid> ha scritto:
> >>>>
> >>>> Nicely planned, thanks Enrico!
> >>>>
> >>>> On Fri, Jan 4, 2019 at 9:33 AM Andor Molnar <andor@apache.org>
wrote:
> >>>>
> >>>>> Awesome!
> >>>>>
> >>>>> I really looking forward to it.
> >>>>>
> >>>>> Andor
> >>>>>
> >>>>>
> >>>>>> On 2019. Jan 3., at 22:34, Enrico Olivelli <eolivelli@gmail.com>
> >>> wrote:
> >>>>>>
> >>>>>> Hi Zookeepers
> >>>>>> Now that we have Maven it is time to set up new CI jobs and
compare
> >>> the
> >>>>>> results with the Ant based build.
> >>>>>>
> >>>>>> My proposal is to set up a few jobs and see the results. When
> >> Norbert
> >>>>>> finishes the migration and we are happy we will drop Ant CI.
> >>>>>>
> >>>>>> I would start with a daily job for master which runs all of
the
> >> test
> >>>>> suites
> >>>>>> + rat + spotbugs.
> >>>>>>
> >>>>>> As a second step I would introduce a new precommit job which
builds
> >>> the
> >>>>>> patch using Maven, so in github we will have two 'status lines'
> >>>>>>
> >>>>>> Then I would add code coverage reports, OWASP....
> >>>>>>
> >>>>>> The final step will be to introduce Jenkins DSL based configuration
> >>> for
> >>>>> CI,
> >>>>>> this way committers will have full control on CI, reviews of
the
> >>>>>> configuration changes will be possible...(we could use Jenkinsfile
> >>>>> approach
> >>>>>> if you prefer)
> >>>>>>
> >>>>>> I am able to work on ASF CI so if you allow me I will start
with
> >> some
> >>>>>> prototype
> >>>>>>
> >>>>>> Enrico
> >>>>>>
> >>>>>> --
> >>>>>>
> >>>>>>
> >>>>>> -- Enrico Olivelli
> >>>>>
> >>>>>
> >>>
> >>
>

Mime
View raw message