zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] athanatos edited a comment on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1
Date Wed, 27 Feb 2019 17:53:44 GMT
athanatos edited a comment on issue #787: ZOOKEEPER-3253: client should not send requests with
cxid=-4, -2, or -1
URL: https://github.com/apache/zookeeper/pull/787#issuecomment-467962868
 
 
   @phunt I was unable to find anything server side that actually compares cxids other than
to check equality.  I believe this patch to be safe so long as two requests with the same
cxid on the same session are not live at the same time -- which a 31 bit cxid is probably
sufficient to ensure.  Note, the current implementation already permits wrapping from MAX
to MIN.  This behavior occurs regularly in our environment and the only misbehavior it seems
to cause is that the requests submitted with a cxid value of -4, -2, or -1 hang or cause a
reconnect.  The patch also includes a test to exercise the behavior specifically.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message