zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mookid8000 opened a new pull request #834: improve error message when JAVA_HOME is set to the wrong value
Date Mon, 25 Feb 2019 15:11:45 GMT
mookid8000 opened a new pull request #834: improve error message when JAVA_HOME is set to the
wrong value
URL: https://github.com/apache/zookeeper/pull/834
 
 
   This is small (Windows-based) developer usability improvement.
   
   When the `JAVA_HOME` environment variable is set, but the value is wrong (so that `JAVA_HOME`
+ `/bin/java.exe` does not point correctly to `java.exe`), the startup script will simply
fail with the message
   ```dos
   Error: JAVA_HOME is incorrectly set.
   ```
   which is a bummer. 😞 
   
   With this tiny change, the error message will be much friendlier:
   ```dos
   Error: JAVA_HOME is incorrectly set: C:\Program Files\Java\jre1.8.0_201\bin
   Expected to find java.exe here: C:\Program Files\Java\jre1.8.0_201\bin\bin\java.exe
   ```
   (in this case showing a situation where one has inadvertently included `/bin` in the `JAVA_HOME`
environment variable).
   
   This will also give a nicer error message in situations, where the JRE has been updated,
and the one pointed to by `JAVA_HOME` has been uninstalled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message