zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] phunt commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation
Date Sun, 24 Feb 2019 20:23:57 GMT
phunt commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience
tar, assembly module and sha512 generation
URL: https://github.com/apache/zookeeper/pull/828#discussion_r259638398
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -660,26 +666,20 @@
         </executions>
       </plugin>
       <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-assembly-plugin</artifactId>
+        <groupId>net.nicoulaj.maven.plugins</groupId>
 
 Review comment:
   Is it the case that maven plugin(s) don't support this functionality? Perhaps a short comment
here would help future folks. I'm not familiar with this plugin (net. nicoulaj) and as such
a short basis for why would help. thx.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message