zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] lvfangmin commented on a change in pull request #796: ZOOKEEPER-3267: Add watcher metrics
Date Wed, 20 Feb 2019 19:27:45 GMT
lvfangmin commented on a change in pull request #796: ZOOKEEPER-3267: Add watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r258640565
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
 ##########
 @@ -106,6 +107,7 @@ public void addDeadWatcher(int watcherBit) {
                 synchronized(processingCompletedEvent) {
                     processingCompletedEvent.wait(100);
                 }
+                ServerMetrics.ADD_DEAD_WATCHER_STALL_TIME.add(100);
 
 Review comment:
   Nice catch, I think we should measure the exact time used when waiting for the signal,
@jhuan31 can you help update this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message