zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn
Date Sat, 16 Feb 2019 04:07:43 GMT
ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn
URL: https://github.com/apache/zookeeper/pull/810#issuecomment-464284238
 
 
   > In general this looks good. If this is a win or not will depend a bit on what you
do with the aggregated ByteBuf at the end tho.
   
   We end up having to squish it all into a single buffer anyway, because the API the data
is passed to doesn't accept multiple buffers. I looked into fixing that but it's a pretty
deep rabbit hole so I'm not going there right now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message