zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nkalmar commented on a change in pull request #821: Fix ant package target: pom.template, zooinspector
Date Thu, 14 Feb 2019 20:14:55 GMT
nkalmar commented on a change in pull request #821: Fix ant package target: pom.template, zooinspector
URL: https://github.com/apache/zookeeper/pull/821#discussion_r256995207
 
 

 ##########
 File path: build.xml
 ##########
 @@ -1010,7 +1013,6 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
           <include name="zookeeper-server/**"/>
           <include name="zookeeper-it/**"/>
         </fileset>
-        <fileset file="${java.server.resources.dir}/pom.template"/>
 
 Review comment:
   this is for the bin-package target, you'll also need a new copy task here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message