zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eolivelli commented on a change in pull request #796: ZOOKEEPER-3267: Add watcher metrics
Date Tue, 12 Feb 2019 06:33:42 GMT
eolivelli commented on a change in pull request #796: ZOOKEEPER-3267: Add watcher metrics
URL: https://github.com/apache/zookeeper/pull/796#discussion_r255818297
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
 ##########
 @@ -106,6 +107,7 @@ public void addDeadWatcher(int watcherBit) {
                 synchronized(processingCompletedEvent) {
                     processingCompletedEvent.wait(100);
                 }
+                ServerMetrics.ADD_DEAD_WATCHER_STALL_TIME.add(100);
 
 Review comment:
   Is 100 right?
   Are we supposing that the abow *wait* always timeouts?
   Is It worth to track the exact time?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message