zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xoiss commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894
Date Fri, 08 Feb 2019 00:27:47 GMT
xoiss commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894
URL: https://github.com/apache/zookeeper/pull/363#issuecomment-461646987
 
 
   Ok... As I remember, it turned out there is bug in the fix proposed by me here in case
of multi-threaded build. So, it remedies the single-threaded build, but breaks the multi-threaded.
   
   The cause is the 'assert' in the else part. I don't remember what was the idea to put it
in the else part... to guarantee what. Surely, the else part never happens in the single-threaded
version. But, it occurs in 100% of cases in the multi-threaded, and process gets SIGABRT.
As soon as I've been using only the single-treaded version those times, I did not notice that
in September 2017. We noticed it later with the different project that uses multi-threaded.
   
   Ok, we have already debugged this and refixed in our locally patched fork, but I have not
updated this request here.
   
   So, I need to rework and rebase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message