zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivmaykov commented on a change in pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments
Date Thu, 07 Feb 2019 18:54:48 GMT
ivmaykov commented on a change in pull request #809: ZOOKEEPER-3272: Clean up netty4 code per
Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/809#discussion_r254821619
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
 ##########
 @@ -82,7 +84,7 @@
 
     ClientCnxnSocketNetty(ZKClientConfig clientConfig) throws IOException {
         this.clientConfig = clientConfig;
-        eventLoopGroup = NettyUtils.newNioOrEpollEventLoopGroup();
+        eventLoopGroup = NettyUtils.newNioOrEpollEventLoopGroup(1 /* nThreads */);
 
 Review comment:
   Probably not worth the trouble. I suspect that by far the common case in a client is connecting
to a single ZK ensemble (per client process), so this optimization would not buy us much and
would introduce additional complexity.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message