zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] normanmaurer commented on a change in pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments
Date Thu, 07 Feb 2019 18:50:16 GMT
normanmaurer commented on a change in pull request #809: ZOOKEEPER-3272: Clean up netty4 code
per Norman Maurer's review comments
URL: https://github.com/apache/zookeeper/pull/809#discussion_r254819694
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
 ##########
 @@ -82,7 +84,7 @@
 
     ClientCnxnSocketNetty(ZKClientConfig clientConfig) throws IOException {
         this.clientConfig = clientConfig;
-        eventLoopGroup = NettyUtils.newNioOrEpollEventLoopGroup();
+        eventLoopGroup = NettyUtils.newNioOrEpollEventLoopGroup(1 /* nThreads */);
 
 Review comment:
   got it... You could consider sharing the `EventLoopGroup` between those if this is feasible.
But again this is just an optimisation and I am not sure if this is easily archiveable 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message