zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
Date Wed, 06 Feb 2019 15:29:16 GMT
anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on
3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-461065009
 
 
   @normanmaurer @ivmaykov Thank you for your reviews.
   
   But.
   
   We're getting a little bit far with this, because I think we have a misunderstanding here.
So, this patch is basically a *backport*, not a brand new patch. The original patch was already
submitted to master, therefore we only need to verify here that this patch is identical to
that.
   
   I appreciate your findings, but we will never gonna commit and never gonna release if we're
going down on this road. So here's my plan:
   
   - verify that this patch is identical to the original on master, if yes, commit,
   - if you find anything during your reviews which is **absolutely critical** and a stable
release cannot be performed due to that, please let me know,
   - otherwise, please open a new Jira with your improvements and I'll make sure that it will
go through the usual patch process: PR, review, commit, backport, etc.
   
   Is that acceptable for you?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message