zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
Date Tue, 05 Feb 2019 20:26:11 GMT
ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing
on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460790256
 
 
   @anmolnar this looks fine to me but let's wait for @normanmaurer since he is going to review
tomorrow. And I think the fix to not leak watchers when connection is closed is necessary,
unless there is another mechanism that cleans up leaked watchers - see my inline comment about
it. I'm fine with not doing it in this PR, but think we should backport it separately before
releasing 3.5. I would be happy to review the backport.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message