zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
Date Tue, 05 Feb 2019 17:27:58 GMT
anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on
3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460727808
 
 
   I'll probably open a separate Jira/pull request for this, but I've just come up with this
during my testing setup. Finally managed to establish Quorum TLS, works perfectly fine, but
besides documentation, ZooKeeper SSL related logs are almost completely missing too.
   
   I'm thinking of adding log messages like:
   ```
   2019-02-05 18:19:57,373 [myid:1] - INFO  [QuorumPeerListener:QuorumCnxManager$Listener@864]
- Creating SSL-only quorum server socket
   ...
   2019-02-05 18:19:57,720 [myid:1] - INFO  [Andors-MacBook-Pro.local/172.30.65.74:4181:UnifiedServerSocket$UnifiedSocket@273]
- Accepted TLS connection from /172.30.65.74:62265
   ...
   2019-02-05 18:19:57,832 [myid:1] - INFO  [WorkerSender[myid=1]:QuorumCnxManager@644] -
SSL handshake complete: 672e39b6[TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256: Socket[addr=Andors-MacBook-Pro.local/172.30.65.74,port=4182,localport=62267]]
   ```
   
   etc. etc. All at INFO level.
   
   I believe it would be extremely beneficial for users who start playing with Quorum TLS
at the first place, but also useful for administrators to get confirmation about the ensemble
is running on TLS for sure. It's not a huge amount of logs, we can keep them at info level.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message