zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tamaashu commented on a change in pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts
Date Tue, 05 Feb 2019 09:57:18 GMT
tamaashu commented on a change in pull request #801: Fix ZOOKEEPER-2625: Introduce explicit
end-of-line setting for shell scripts
URL: https://github.com/apache/zookeeper/pull/801#discussion_r253795508
 
 

 ##########
 File path: bin/.gitattributes
 ##########
 @@ -0,0 +1 @@
+*.sh eol=lf
 
 Review comment:
   I think we should not have `lf` here, but `auto`.
   We still support windows to build ZooKeeper, we should be able to edit shell files there
too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message