From dev-return-77344-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Jan 18 06:09:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E387E180663 for ; Fri, 18 Jan 2019 06:09:05 +0100 (CET) Received: (qmail 30283 invoked by uid 500); 18 Jan 2019 05:09:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 30271 invoked by uid 99); 18 Jan 2019 05:09:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jan 2019 05:09:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D127BD1DBE for ; Fri, 18 Jan 2019 05:09:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tG4ldUCLxRoS for ; Fri, 18 Jan 2019 05:09:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A4B7161155 for ; Fri, 18 Jan 2019 05:09:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C3267E2693 for ; Fri, 18 Jan 2019 05:09:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 33F762565C for ; Fri, 18 Jan 2019 05:09:00 +0000 (UTC) Date: Fri, 18 Jan 2019 05:09:00 +0000 (UTC) From: "Hudson (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16745789#comment-16745789 ]=20 Hudson commented on ZOOKEEPER-3232: ----------------------------------- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #194 (Se= e [https://builds.apache.org/job/Zookeeper-trunk-single-thread/194/]) ZOOKEEPER-3232: make the log of notification about LE more readable (fangmi= n: rev fd465ebf5380319b0ec9415ab832b01046e131ff) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/= FastLeaderElection.java > make the log of notification about LE more readable > --------------------------------------------------- > > Key: ZOOKEEPER-3232 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3232 > Project: ZooKeeper > Issue Type: Improvement > Components: leaderElection > Reporter: maoling > Assignee: maoling > Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > the log of notification about LE is very important to help us to see the = process of LE:e.g. > {code:java} > 2019-01-01 16:29:27,494 [myid:2] - INFO [WorkerReceiver[myid=3D2]:FastLea= derElection@595] - Notification: 1 (message format version), 3 (n.leader), = 0x60b3dc215 (n.zxid), 0x3 (n.round), FOLLOWING (n.state), 1 (n.sid), 0x7 (n= .peerEpoch) LOOKING (my state){code} > the current log have some problems: > 1:don't use the placeholder(other:+),don't in the style of k:v=EF=BC=88an= timan=EF=BC=89 > 2.the properties in the logs are very messed(no group by,no order), not e= asy to read. > 3.the value about version is HEX which don't have the 0x prefix. -- This message was sent by Atlassian JIRA (v7.6.3#76005)