From dev-return-77535-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Jan 25 22:20:33 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 27AEE180608 for ; Fri, 25 Jan 2019 22:20:32 +0100 (CET) Received: (qmail 33597 invoked by uid 500); 25 Jan 2019 21:20:32 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 33586 invoked by uid 99); 25 Jan 2019 21:20:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jan 2019 21:20:32 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 Message-ID: <154845123151.26359.12676637806570813757.gitbox@gitbox.apache.org> Date: Fri, 25 Jan 2019 21:20:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on a change in pull request #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#discussion_r251139004 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ########## @@ -1510,6 +1511,11 @@ public void close() throws IOException { * the server. Thus, getXid() must be public. */ synchronized public int getXid() { + // xid values of -4, -2, and -1 are special, see SendThread.readResponse Review comment: What about introducing constants for these special values ? (and replace in readResponse) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services