From dev-return-77486-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jan 24 12:35:59 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 31DB618062C for ; Thu, 24 Jan 2019 12:35:59 +0100 (CET) Received: (qmail 63564 invoked by uid 500); 24 Jan 2019 11:35:53 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 63519 invoked by uid 99); 24 Jan 2019 11:35:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jan 2019 11:35:53 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: =?utf-8?q?=5BGitHub=5D_anmolnar_commented_on_a_change_in_pull_request_=23?= =?utf-8?q?784=3A_ZOOKEEPER-974=3A_Allow_a_configurable_ZooKeeper_server_s?= =?utf-8?q?ocket_listen_ba=E2=80=A6?= Message-ID: <154832975263.10802.16621506145297673500.gitbox@gitbox.apache.org> Date: Thu, 24 Jan 2019 11:35:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar commented on a change in pull request #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba… URL: https://github.com/apache/zookeeper/pull/784#discussion_r250568540 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerConf.java ########## @@ -60,6 +60,12 @@ * The key in the map returned by {@link #toMap()} for the server ID. */ public static final String KEY_SERVER_ID = "server_id"; + /** + * The key in the map returned by {@link #toMap()} for the server socket + * listen backlog. + */ + public static final String KEY_CLIENT_PORT_LISTEN_BACKLOG Review comment: How is this class related to `ServerConfig`? Looks like we have 2 different classes for the same purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services