From dev-return-77367-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Jan 19 01:16:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3890B18077D for ; Sat, 19 Jan 2019 01:16:04 +0100 (CET) Received: (qmail 30116 invoked by uid 500); 19 Jan 2019 00:16:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 29896 invoked by uid 99); 19 Jan 2019 00:16:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jan 2019 00:16:03 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext Message-ID: <154785696249.23989.4208234689656351753.gitbox@gitbox.apache.org> Date: Sat, 19 Jan 2019 00:16:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249220918 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ########## @@ -17,10 +17,28 @@ */ package org.apache.zookeeper.common; +import org.apache.zookeeper.common.X509Exception.KeyManagerException; Review comment: nit: revert import reorder? Or fix your import organizer to do java.* -> javax.* -> everything else ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services