From dev-return-77315-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jan 17 22:38:50 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4D1B318063F for ; Thu, 17 Jan 2019 22:38:49 +0100 (CET) Received: (qmail 90009 invoked by uid 500); 17 Jan 2019 21:38:47 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 89985 invoked by uid 99); 17 Jan 2019 21:38:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2019 21:38:47 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext Message-ID: <154776112733.26341.6204309449836050422.gitbox@gitbox.apache.org> Date: Thu, 17 Jan 2019 21:38:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248847815 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ########## @@ -238,18 +239,19 @@ public int getSslHandshakeTimeoutMillis() { return result; } + @SuppressWarnings("unchecked") public SSLContext createSSLContext(ZKConfig config) throws SSLContextException { - if (config.getProperty(sslClientContextProperty) != null) { - LOG.debug("Loading SSLContext from property '" + sslClientContextProperty + "'"); - String sslClientContextClass = config.getProperty(sslClientContextProperty); + if (config.getProperty(sslContextSupplierClassProperty) != null) { + LOG.debug("Loading SSLContext supplier from property '" + sslContextSupplierClassProperty + "'"); Review comment: nit: enclose this in a `if (LOG.isDebugEnabled()) { ... }` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services