From dev-return-77292-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jan 17 17:16:56 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 37EE0180675 for ; Thu, 17 Jan 2019 17:16:56 +0100 (CET) Received: (qmail 87539 invoked by uid 500); 17 Jan 2019 16:16:55 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 87528 invoked by uid 99); 17 Jan 2019 16:16:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2019 16:16:55 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: =?utf-8?q?=5BGitHub=5D_anmolnar_commented_on_issue_=23760=3A_ZOOKEEPER-32?= =?utf-8?q?15=3A_Handle_Java_9/11_additions_of_covariant_return_types_?= =?utf-8?b?4oCm?= Message-ID: <154774181467.23034.10002127678849727491.gitbox@gitbox.apache.org> Date: Thu, 17 Jan 2019 16:16:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types … URL: https://github.com/apache/zookeeper/pull/760#issuecomment-455232025 Thanks @vivekpatani . I think a patch is needed anyway to modify ant/maven scripts to use release flag instead of javac.target. Because now one could mistakenly make the assumption of ZooKeeper correctly cross-compiles for JDK8. Would you mind creating or modifying your existing patch accordingly? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services