From dev-return-77255-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Jan 16 14:18:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5818D180675 for ; Wed, 16 Jan 2019 14:18:46 +0100 (CET) Received: (qmail 38025 invoked by uid 500); 16 Jan 2019 13:18:45 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 38014 invoked by uid 99); 16 Jan 2019 13:18:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Jan 2019 13:18:45 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 Message-ID: <154764472480.32339.6070655727845028334.gitbox@gitbox.apache.org> Date: Wed, 16 Jan 2019 13:18:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#issuecomment-454775677 @anmolnar thank you for your review You are suggesting me to add a bunch of SuppressFBWarnings and do not add so many synchronized blocks, aren't you ? Do you want me to drop all of them or only the most dangerous ? Code is currently working well (before this patch) and I suppose it will continue to work even without those new "synchronized" blocks. I will wait a second "ack" from you and then I will fix the patch as soon as possible so that we can move forward with Maven migration. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services