From dev-return-77076-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Jan 9 16:21:25 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B92FD180676 for ; Wed, 9 Jan 2019 16:21:24 +0100 (CET) Received: (qmail 85833 invoked by uid 500); 9 Jan 2019 15:21:23 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 85822 invoked by uid 99); 9 Jan 2019 15:21:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2019 15:21:23 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: =?utf-8?q?=5BGitHub=5D_anmolnar_commented_on_issue_=23760=3A_ZOOKEEPER-32?= =?utf-8?q?15=3A_Handle_Java_9/11_additions_of_covariant_return_types_?= =?utf-8?b?4oCm?= Message-ID: <154704728311.23752.4516510721877582012.gitbox@gitbox.apache.org> Date: Wed, 09 Jan 2019 15:21:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types … URL: https://github.com/apache/zookeeper/pull/760#issuecomment-452734142 @vivekpatani Since Java 1.9 there's a `--release` switch for the javac compiler which sets the "source", "target" and "bootclasspath" properties in order to properly cross-compile. Wouldn't it be better to use that for cross-compile ZooKeeper instead of code change? I tested it on branch-3.4 and it works fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services