zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2641) AvgRequestLatency metric improves to be more accurate
Date Mon, 07 Jan 2019 17:53:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736101#comment-16736101

Hudson commented on ZOOKEEPER-2641:

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #177 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/177/])
ZOOKEEPER-2641: AvgRequestLatency metric improves to be more accurate (andor: rev bc992480ec938a3fad4b90f75a52dd186e1b968a)
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandsTest.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/SimpleCounter.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/command/MonitorCommand.java
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/ServerStatsTest.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerBean.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/FourLetterWordsTest.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/ServerMetricsTest.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerStats.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMXBean.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxCounter.java
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/Metric.java

> AvgRequestLatency metric improves to be more accurate
> -----------------------------------------------------
>                 Key: ZOOKEEPER-2641
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2641
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.7, 3.4.9
>            Reporter: Allen Chan
>            Assignee: maoling
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
> I posted a thread on the mailing list about finding AvgRequestLatency metric to be 0
all the time. I believe this is a valuable metric because it is useful to baseline performance
of ZK and know when something is going wrong. 
> Another user (Arshad Mohammad) wrote up these notes. I am not a developer so i do not
have ability to patch this. Filing this so hopefully someone with developer abilities can
add this improvement. 
> "I find two reason whys AvgRequestLatency is almost all the time 0
> 1) Ping requests are counted the most:
> AvgRequestLatency is calculated as
> AvgRequestLatency=totalLatency/count
> Ping requests come very often and complete very fast, these request add
> nothing to totalLatency but add one to count.
> 2) Wrong data type is chosen to store AvgRequestLatency:
> AvgRequestLatency is calculated and store as the long value instead of
> double vlaue.
> In my opinion ZooKeeper code should be modified to improve this metrics
> i) Ping request should be ignored while recording the statistics or at
> least should be configurable whether to ignore or not. If ping request is
> not counted even other metrics will be more meaningful.
> ii)  AvgRequestLatency should be of double type"

This message was sent by Atlassian JIRA

View raw message