zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2284) LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully
Date Wed, 09 Jan 2019 01:42:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737737#comment-16737737
] 

Hadoop QA commented on ZOOKEEPER-2284:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12764303/ZOOKEEPER-2284-04.patch
  against trunk revision 46fc819622bf08cbd0781dea279aff734b492902.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3722//console

This message is automatically generated.

> LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully
> -----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2284
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2284
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Mohammad Arshad
>            Assignee: maoling
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5
>
>         Attachments: ZOOKEEPER-2284-01.patch, ZOOKEEPER-2284-02.patch, ZOOKEEPER-2284-03.patch,
ZOOKEEPER-2284-04.patch
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> {{LogFormatter}} and {{SnapshotFormatter}} does not handle FileNotFoundException gracefully.
If file no exist then these classes propagate the exception to console.
> {code}
> Exception in thread "main" java.io.FileNotFoundException: log.1 (The system cannot find
the file specified)
>         at java.io.FileInputStream.open(Native Method)
>         at java.io.FileInputStream.<init>(FileInputStream.java:146)
>         at java.io.FileInputStream.<init>(FileInputStream.java:101)
>         at org.apache.zookeeper.server.LogFormatter.main(LogFormatter.java:49)
> {code}
>  File existence should be validated and appropriate message should be displayed on console
if file does not exist



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message