zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Norbert Kalmar <nkal...@cloudera.com.INVALID>
Subject Re: Branch 3.4 and Maven...some problems found while porting Spotbugs patch
Date Mon, 14 Jan 2019 11:43:20 GMT
Never mind, jtoaster only required in 3.4

I will remove building the contrib on all branches anyway, and put it in
full-build profile only.

On Mon, Jan 14, 2019 at 12:27 PM Norbert Kalmar <nkalmar@cloudera.com>
wrote:

> I see, thanks!
>
> I just manually added the jar with the install-plugin, which generated the
> required files and directory structure. Now it works, even after I delete
> my .m2 directory. I will add it to the PR.
>
> I'll also check 3.5 and master, they might need the change too.
> And I will remove contrib build and add it to the full-build profile. At
> least ant shipped ZK with 3 of the contrib jars, so I figure it is a good
> idea to keep those for now.
>
> Regards,
> Norbert
>
> On Mon, Jan 14, 2019 at 11:38 AM Enrico Olivelli <eolivelli@gmail.com>
> wrote:
>
>> The maven-install plugin does not work.
>> If you try with a brand new Maven Repository you wlil see the build fail.
>> I guess this is because Maven wants to resolve dependencies before
>> running the maven install plugin.
>>
>> It will be also good not to build "contrib" modules by default
>> How does this idea sounds to you ?
>>
>> Enrico
>>
>> Il giorno lun 14 gen 2019 alle ore 10:33 Norbert Kalmar
>> <nkalmar@cloudera.com.invalid> ha scritto:
>> >
>> > I fixed the versions: https://github.com/apache/zookeeper/pull/772
>> > But this is just the same fix your patch contains Enrico (but anyway, we
>> > can have it in a separate PR.)
>> >
>> > The error in 2) is because somehow the dependency did not install in
>> local
>> > maven repository. ZooInspector has a jar attached in the source code,
>> that
>> > is required to be on the classpath. The "nice" way to do this in maven
>> > (unfortunately, it is not in central repo), is to install the jar in the
>> > local .m2 repo. I do this in the initialization phase with
>> > maven-install-plugin.
>> >
>> > I think the problem is that after you updated the versions, you have to
>> > force snapshots to update dependencies with the -U switch.
>> >
>> > And one more thing: unfortunately versions are also wrong on 3.5, so I
>> will
>> > create a PR for that also.
>> >
>> > Regards,
>> > Norbert
>> >
>> >
>> > On Sun, Jan 13, 2019 at 11:46 AM Norbert Kalmar <nkalmar@cloudera.com>
>> > wrote:
>> >
>> > > Hi Enrico,
>> > >
>> > > I can agree on skipping spotbugs on contrib. There was even a plan to
>> > > remove most contrib to a seperate top-level project, out of
>> ZooKeeper. Most
>> > > of them isn't even maintained for a long time now.
>> > > Anyway, that's a non-binding +1 from me.
>> > >
>> > > I will check the pom's on 3.4, sorry about that. Looks like even
>> though I
>> > > double checked the versions still left some errors during backport. I
>> will
>> > > have a patch ready today or tomorrow.
>> > > And that should also fix 3) of course.
>> > >
>> > > Thanks Enrico for reporting this!
>> > >
>> > > Regards,
>> > > Norbert
>> > >
>> > > On Fri, Jan 11, 2019 at 11:28 PM Enrico Olivelli <eolivelli@gmail.com
>> >
>> > > wrote:
>> > >
>> > >> Hi,
>> > >> we have some problems on 3.4 branch with Maven migration.
>> > >>
>> > >> 1) There are references to 3.6.0-SNAPSHOT
>> > >>
>> > >>
>> https://github.com/apache/zookeeper/blob/b8044eae3e700650a646969352a508122a4e5a98/zookeeper-contrib/zookeeper-contrib-loggraph/pom.xml#L26
>> > >>
>> > >> 2) Build fails with this error (after fixing poms):
>> > >> [INFO]
>> > >>
>> ------------------------------------------------------------------------
>> > >> [ERROR] Failed to execute goal on project
>> > >> zookeeper-contrib-zooinspector: Could not resolve dependencies for
>> > >> project
>> > >>
>> org.apache.zookeeper:zookeeper-contrib-zooinspector:jar:3.4.14-SNAPSHOT:
>> > >> Could not find artifact com.nitido.utils:toaster:jar:1.0.4 in central
>> > >> (https://repo.maven.apache.org/maven2) -> [Help 1]
>> > >>
>> > >> 3) I am porting spotbugs patch now, but there came a lot of new code,
>> > >> so I had to fix recipes and I have disabled the 'contrib' modules
>> > >> which are not compliant at all with spotbugs
>> > >> 4) There are a lot of spotbugs errors on 3.4 branch, not found on
>> 3.5 and
>> > >> master
>> > >>
>> > >> This is my patch which is solving 1) and 3) and 4)
>> > >> https://github.com/apache/zookeeper/pull/764
>> > >>
>> > >> I can split it, let me know.
>> > >>
>> > >> An alternative approach is to fix the poms in one patch (Norbert?).
>> > >>
>> > >> I guess I will have to re-work on spotbugs on master and branch-3.5
>> > >> now that recipes and contrib landed to Maven world.
>> > >>
>> > >> I would prefer to skip Spotbugs on "contrib".
>> > >> I think spotbugs must pass in "recipes", if you take a look at my
>> > >> commit, there are many warnings, and I think they may be real bugs
>> > >>
>> > >> Cheers
>> > >> Enrico
>> > >>
>> > >
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message