zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
Date Thu, 31 Jan 2019 22:56:40 GMT
ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on
3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-459538891
 
 
   @anmolnar the non-netty networking code is not significantly different between 3.5 and
master. I checked out anmolnar:ZOOKEEPER-3204 and ran the following command to get a diff:
   
   `git diff HEAD..upstream/master zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxnFactory.java zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocket.java zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java`
   
   I don't even think we even have to backport ZOOKEEPER-3177 (though we could). And all relevant
tests with your branch pass on my machine. I will take a closer look at the commit to make
sure there were no merge bugs introduced, expect to give my +1 within a day.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message