zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arshadmohammad commented on a change in pull request #324: ZOOKEEPER-2843: auth_to_local now supports reading rules from a file
Date Thu, 31 Jan 2019 05:45:34 GMT
arshadmohammad commented on a change in pull request #324: ZOOKEEPER-2843: auth_to_local now
supports reading rules from a file
URL: https://github.com/apache/zookeeper/pull/324#discussion_r252541655
 
 

 ##########
 File path: src/java/main/org/apache/zookeeper/server/auth/KerberosName.java
 ##########
 @@ -356,6 +358,9 @@ String apply(String[] params) throws IOException {
    */
   public static void setConfiguration() throws IOException {
 
 Review comment:
   I was thinking this could be a problem when rules are separated with new line character
but seems we can configure rules without new line character like security.auth_to_local= RULE:[2:$1]
DEFAULT in zoo.cfg. Based this and already discussed facts, changes proposed in PR are not
required. We can close this PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message