zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] maoling commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba…
Date Tue, 29 Jan 2019 07:23:50 GMT
maoling commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket
listen ba…
URL: https://github.com/apache/zookeeper/pull/784#issuecomment-458434115
 
 
   @joshelser 
   - About the unit test,since the guarantee is from the `bind()` api from `java-nio` and
`netty`.so it's not very easy to write a UT.Woo! 
   - some asserts about the setting value of `clientPortBacklog` are already enough.
   - if really need a UT, you can set `clientPortBacklog` = 3,then do a concurrent requests(client
concurrency=20) for zk server,then catch the timeout of some clients,then set `clientPortBacklog`
= 50, assert to see no timeout of any clients.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message