zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] enixon commented on a change in pull request #789: ZOOKEEPER-3257: Merge count and byte update of Stat
Date Mon, 28 Jan 2019 20:52:54 GMT
enixon commented on a change in pull request #789: ZOOKEEPER-3257: Merge count and byte update
of Stat
URL: https://github.com/apache/zookeeper/pull/789#discussion_r251588161
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
 ##########
 @@ -364,57 +368,16 @@ public void updateCount(String lastPrefix, int diff) {
             return;
         }
         synchronized (node) {
+            // todo nixon?
 
 Review comment:
   Good catch! I forgot to remove my "read this" marker.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message